From 3434b5cbdef4f63d61db2d50dc61f0c4a48b953a Mon Sep 17 00:00:00 2001 From: Il`ya Date: Sun, 26 Jan 2020 03:49:35 +0300 Subject: [PATCH] =?UTF-8?q?=D0=9F=D0=BE=D0=BB=D0=B5=20product=5Fid=20?= =?UTF-8?q?=D0=BA=D0=BB=D0=B0=D1=81=D1=81=D0=B0=20AutoRenewable=20=D1=82?= =?UTF-8?q?=D0=B5=D0=BF=D0=B5=D1=80=D1=8C=20=D0=BE=D0=BF=D1=86=D0=B8=D0=BE?= =?UTF-8?q?=D0=BD=D0=B0=D0=BB=D1=8C=D0=BD=D0=BE=20#182?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- tests/conftest.py | 2 +- tests/test_auto_renewable.py | 9 ++++----- yandex_music/account/auto_renewable.py | 11 ++++++----- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index cd385bd..559aebe 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -328,7 +328,7 @@ def permissions(): @pytest.fixture(scope='session') def auto_renewable(product): return AutoRenewable(TestAutoRenewable.expires, TestAutoRenewable.vendor, TestAutoRenewable.vendor_help_url, - TestAutoRenewable.product_id, product, TestAutoRenewable.finished, TestAutoRenewable.order_id) + product, TestAutoRenewable.finished, TestAutoRenewable.product_id, TestAutoRenewable.order_id) @pytest.fixture(scope='session') diff --git a/tests/test_auto_renewable.py b/tests/test_auto_renewable.py index 3e8f7a8..8881f34 100644 --- a/tests/test_auto_renewable.py +++ b/tests/test_auto_renewable.py @@ -26,13 +26,12 @@ class TestAutoRenewable: def test_de_json_required(self, client, product): json_dict = {'expires': self.expires, 'vendor': self.vendor, 'vendor_help_url': self.vendor_help_url, - 'product_id': self.product_id, 'product': product.to_dict(), 'finished': self.finished} + 'product': product.to_dict(), 'finished': self.finished} auto_renewable = AutoRenewable.de_json(json_dict, client) assert auto_renewable.expires == self.expires assert auto_renewable.vendor == self.vendor assert auto_renewable.vendor_help_url == self.vendor_help_url - assert auto_renewable.product_id == self.product_id assert auto_renewable.product == product assert auto_renewable.finished == self.finished @@ -51,9 +50,9 @@ class TestAutoRenewable: assert auto_renewable.order_id == self.order_id def test_equality(self, product): - a = AutoRenewable(self.expires, self.vendor, self.vendor_help_url, self.product_id, product, self.finished) - b = AutoRenewable(self.expires, '', self.vendor_help_url, '', product, self.finished) - c = AutoRenewable(self.expires, self.vendor, self.vendor_help_url, self.product_id, product, self.finished) + a = AutoRenewable(self.expires, self.vendor, self.vendor_help_url, product, self.finished) + b = AutoRenewable(self.expires, '', self.vendor_help_url, None, self.finished) + c = AutoRenewable(self.expires, self.vendor, self.vendor_help_url, product, self.finished) assert a != b assert hash(a) != hash(b) diff --git a/yandex_music/account/auto_renewable.py b/yandex_music/account/auto_renewable.py index 3a1baa6..1ebe44a 100644 --- a/yandex_music/account/auto_renewable.py +++ b/yandex_music/account/auto_renewable.py @@ -25,9 +25,10 @@ class AutoRenewable(YandexMusicObject): vendor (:obj:`str`): Продавец. vendor_help_url (:obj:`str`): Ссылка на страницу помощи продавца. product_id (:obj:`str`): Уникальный идентификатор продукта. - product (:obj:`yandex_music.Product`): Объект класса :class:`yandex_music.Product` представляющий продукт. - order_id (:obj:`int`): Уникальный идентификатор заказа. finished (:obj:`bool`): Завершенность автопродления. + product (:obj:`yandex_music.Product`, optional): Объект класса :class:`yandex_music.Product` представляющий + продукт. + order_id (:obj:`int`): Уникальный идентификатор заказа. client (:obj:`yandex_music.Client`, optional): Объект класса :class:`yandex_music.Client` представляющий клиент Yandex Music. **kwargs: Произвольные ключевые аргументы полученные от API. @@ -37,23 +38,23 @@ class AutoRenewable(YandexMusicObject): expires: str, vendor: str, vendor_help_url: str, - product_id: str, product: Optional['Product'], finished: bool, + product_id: Optional[str] = None, order_id: Optional[int] = None, client: Optional['Client'] = None, **kwargs) -> None: self.expires = expires self.vendor = vendor self.vendor_help_url = vendor_help_url - self.product_id = product_id self.product = product self.finished = finished + self.product_id = product_id self.order_id = order_id self.client = client - self._id_attrs = (self.expires, self.vendor, self.vendor_help_url, self.product_id, self.product, self.finished) + self._id_attrs = (self.expires, self.vendor, self.vendor_help_url, self.product, self.finished) @classmethod def de_json(cls, data: dict, client: 'Client') -> Optional['AutoRenewable']: