emit body and doctype on iframe embed endpoint (#640)

2022-06-16 18:46:41 +02:00 · 2022-06-16 18:46:41 +02:00 · 5e827c91aa
--- a/src/routes/embed.nim
+++ b/src/routes/embed.nim
@ -25,7 +25,7 @@ proc createEmbedRouter*(cfg: Config) =
      if convo == nil or convo.tweet == nil:
        resp Http404

-      resp $renderTweetEmbed(convo.tweet, path, prefs, cfg, request)
+      resp renderTweetEmbed(convo.tweet, path, prefs, cfg, request)

    get "/embed/Tweet.html":
      let id = @"id"
--- a/src/views/embed.nim
+++ b/src/views/embed.nim
@ -15,7 +15,8 @@ proc renderVideoEmbed*(tweet: Tweet; cfg: Config; req: Request): string =
  let node = buildHtml(html(lang="en")):
    renderHead(prefs, cfg, req, video=vidUrl, images=(@[thumb]))

-    tdiv(class="embed-video"):
-      renderVideo(get(tweet.video), prefs, "")
+    body:
+      tdiv(class="embed-video"):
+        renderVideo(get(tweet.video), prefs, "")

  result = doctype & $node
--- a/src/views/tweet.nim
+++ b/src/views/tweet.nim
@ -7,6 +7,9 @@ import renderutils
 import ".."/[types, utils, formatters]
 import general

+const
+  doctype = "<!DOCTYPE html>\n"
+
 proc getSmallPic(url: string): string =
  result = url
  if "?" notin url and not url.endsWith("placeholder.png"):
@ -364,7 +367,12 @@ proc renderTweet*(tweet: Tweet; prefs: Prefs; path: string; class=""; index=0;
        a(class="show-thread", href=("/i/status/" & $tweet.threadId)):
          text "Show this thread"

-proc renderTweetEmbed*(tweet: Tweet; path: string; prefs: Prefs; cfg: Config; req: Request): VNode =
-  buildHtml(tdiv(class="tweet-embed")):
+proc renderTweetEmbed*(tweet: Tweet; path: string; prefs: Prefs; cfg: Config; req: Request): string =
+  let node = buildHtml(html(lang="en")):
    renderHead(prefs, cfg, req)
-    renderTweet(tweet, prefs, path, mainTweet=true)
+
+    body:
+      tdiv(class="tweet-embed"):
+        renderTweet(tweet, prefs, path, mainTweet=true)
+
+  result = doctype & $node