コミットグラフ

19 コミット

作成者 SHA1 メッセージ 日付
Samantaz Fox 7e648840a1
Move InfoException to exceptions.cr 2022-07-19 21:05:49 +02:00
Samantaz Fox 96afc1a45d
Revert html escaping of backtrace 2022-05-01 13:40:02 +02:00
Leo 6f705b053a
Updates the URL of the var url_faq (#3016) 2022-04-09 08:20:28 +02:00
Samantaz Fox 76cc8ac66b
HTML escape error message 2022-02-08 01:48:44 +01:00
Samantaz Fox 2d949834e9
Make 'additional_fields' optional in JSON error template functions
This allows us to de-duplicate functions
2022-01-28 02:19:53 +01:00
Samantaz Fox c7b74aa8b4
Remove useless 'locale' argument from error template functions 2022-01-28 02:19:53 +01:00
Samantaz Fox 8c2495a399
Apply suggestions from review 2022-01-17 21:47:29 +01:00
Samantaz Fox 34a79c5f1e
Don't show "next steps" message with a stack trace
Usually, next steps are after the error message.
Here, we want the same options to be right above the stack trace,
so users are less likely to report duplicates.
2022-01-16 16:15:23 +01:00
Samantaz Fox a2600acfa9
Improve crash page messages
* Ask to read the FAQ and search for existing issues on Github
* Include links to FAQ and directly to a new github issue
* Github issue title is automatically based on exception name
* Improved HTML
* Minor languages changes
2022-01-16 16:15:23 +01:00
Samantaz Fox 139786b9ef
i18n: pass only the ISO code string to 'translate()'
Don't use the whole Hash everywhere.
Also fall back nicely to english string if no translation exists.
2021-11-21 01:50:11 +01:00
syeopite dd8c412abc
Fix Style/IsAFilter issues 2021-10-25 01:14:08 -07:00
syeopite 2f54ec4e18
Fix locale consistency for err template redirects 2021-06-19 04:17:46 -07:00
syeopite b9cd40fe1e
Add redirect buttons to error template 2021-06-19 04:16:18 -07:00
saltycrys b45f371911 Make config a constant
Instead of passing around `config` there is now the global `CONFIG`.
2021-01-23 19:39:04 +01:00
saltycrys 8b56a038b7 Set content type for HTML error helpers
This fixes `Unexpected char '<' at 1:1` errors caused by content type mismatch.
2021-01-04 05:24:08 +01:00
saltycrys b409cdece5 Improve error message 2
Electric Boogaloo

The long backtrace has been moved into a `<details>` HTML element, as suggested
by @B0pol. To make the error still visible it has been added to the top under
`Title:`. This also encourages informative issue titles.
2020-12-01 13:41:19 +01:00
TheFrenchGhosty ca781651cb Fix formatting of #1504 2020-11-30 15:56:01 +01:00
saltycrys 92bb477f68 Improve error message
The error message has been reworded and the issue template now includes the
date, route, version and backtrace.
2020-11-30 13:02:35 +01:00
saltycrys 3dac33ffba
Add backtraces to errors (#1498)
Error handling has been reworked to always go through the new `error_template`,
`error_json` and `error_atom` macros.
They all accept a status code followed by a string message or an exception
object. `error_json` accepts a hash with additional fields as third argument.

If the second argument is an exception a backtrace will be printed, if it is a
string only the string is printed. Since up till now only the exception message
was printed a new `InfoException` class was added for situations where no
backtrace is intended but a string cannot be used.

`error_template` with a string message automatically localizes the message.
Missing error translations have been collected in https://github.com/iv-org/invidious/issues/1497
`error_json` with a string message does not localize the message. This is the
same as previous behavior. If translations are desired for `error_json` they
can be added easily but those error messages have not been collected yet.

Uncaught exceptions previously only printed a generic message ("Looks like
you've found a bug in Invidious. [...]"). They still print that message
but now also include a backtrace.
2020-11-30 10:59:21 +01:00